Import member operator functions as static members #32293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribozavr
reviewed
Jun 10, 2020
gribozavr
reviewed
Jun 10, 2020
gribozavr
reviewed
Jun 10, 2020
gribozavr
reviewed
Jun 10, 2020
gribozavr
reviewed
Jun 10, 2020
Those are marked as `inout` and should not be bridged.
to enum values
MForster
commented
Jun 15, 2020
Contributor
Author
MForster
left a comment
MForster
left a comment
There was a problem hiding this comment.
This is now in a state where I'd be mostly happy with it. Some tests need fixing for non-Linux platforms, but I think it is ready for review.
to better fit the overall naming scheme
gribozavr
reviewed
Jun 16, 2020
gribozavr
reviewed
Jun 16, 2020
gribozavr
reviewed
Jun 16, 2020
gribozavr
reviewed
Jun 16, 2020
gribozavr
reviewed
Jun 16, 2020
Co-authored-by: Dmitri Gribenko <[email protected]>
Co-authored-by: Dmitri Gribenko <[email protected]>
Co-authored-by: Dmitri Gribenko <[email protected]>
gribozavr
reviewed
Jun 16, 2020
gribozavr
reviewed
Jun 16, 2020
gribozavr
approved these changes
Jun 16, 2020
gribozavr
approved these changes
Jun 16, 2020
We can't yet call member functions correctly on Windows.
MForster
commented
Jul 2, 2020
Contributor
Author
MForster
left a comment
MForster
left a comment
There was a problem hiding this comment.
I've addressed the remaining issues. I think this is now ready for merging.
@gribozavr can you take another look before I merge?
Contributor
Author
|
@swift-ci please test |
Contributor
|
Build failed |
gribozavr
reviewed
Jul 3, 2020
gribozavr
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to
ClangImporterto import C++ member function operators as static methods into Swift.The left-hand-side operand, which gets passed as the
thispointer to the C++ function is represented as an additional first parameter in the Swift method. It gets mapped back in SILGen.