[build] set linker parameters in a single way#30339
Merged
edymtt merged 1 commit intoswiftlang:masterfrom Mar 11, 2020
Merged
Conversation
After noticing that also in CMake 3.16 the LINKER: prefix is not expanded correctly when used in `target_link_options`, prefer to set the linker parameters in a more verbose way and leave a comment behind on when this behavior was observed in case we want to change the implementation later. Follow up to swiftlang#29636. Addresses rdar://problem/59732421
Contributor
Author
|
@swift-ci Please smoke test |
compnerd
approved these changes
Mar 10, 2020
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Ugh, seems unfortunate, however, this isn't really that terrible.
shahmishal
approved these changes
Mar 11, 2020
Contributor
Author
|
@swift-ci please test Windows platform |
Contributor
Author
|
The failure is Windows PR testing is already present in master and not related to this change. |
edymtt
added a commit
that referenced
this pull request
Mar 24, 2020
Match the same fix as #30339 for `AddSwiftStdlib.cmake`. Addresses rdar://problem/60791444
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After noticing that also in CMake 3.16 the LINKER: prefix is not
expanded correctly when used in
target_link_options, prefer to set thelinker parameters in a more verbose way and leave a comment behind on
when this behavior was observed in case we want to change the
implementation later.
Follow up to #29636.
Addresses rdar://problem/59732421