[build][gardening] adjust framework paths #29507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collate -F with the framework path to avoid unwanted deduplication of options by `target_compile_options` (which is the case after swiftlang#29451) -- this way no undesired side effects are introduced should a new search path be added. Addresses rdar://problem/58934566
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test Windows platform |
compnerd
approved these changes
Jan 28, 2020
Member
|
@swift-ci please test Windows platform |
shahmishal
approved these changes
Jan 28, 2020
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Jan 29, 2020
This is a follow to swiftlang#29507 addressing one more place in which we need to collate -F with the framework path Addresses rdar://problem/58934566
edymtt
added a commit
that referenced
this pull request
Jan 29, 2020
This is a follow to #29507 addressing one more place in which we need to collate -F with the framework path Addresses rdar://problem/58934566
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collate -F with the framework path to avoid unwanted deduplication of options by
target_compile_options(which is the case after #29451) -- this way no undesired side effects are introduced should a new search path be added.Addresses rdar://problem/58934566