[Diagnostics] Add a special case diagnostic for call to init on `Void…#29504
Merged
Conversation
…` with arguments Expressions like `Void(...)` have a special locator which ends at `FunctionArgument` instead of `ApplyArgument` which makes it possible to type-check `Void()` call successfully. "extraneous arguments" diagnostic needs to handle such situations specifically e.g. `Void(0)`.
Contributor
Author
|
@swift-ci please smoke test |
hborla
approved these changes
Jan 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…` with arguments
Expressions like
Void(...)have a special locator which ends atFunctionArgumentinstead ofApplyArgumentwhich makes it possibleto type-check
Void()call successfully. "extraneous arguments" diagnosticneeds to handle such situations specifically e.g.
Void(0).