[Diagnostics] Don't re-typecheck function expression associated with various calls#29490
Merged
xedin merged 3 commits intoJan 28, 2020
Merged
Conversation
… be a hole If type variable is allowed to be a hole and it can't be bound to this particular (full resolved) type, just ignore this binding instead of re-trying it later.
…ying arguments If a type variable representing "function type" is a hole or it could be bound to some concrete type with a help of a fix, let's propagate holes to the "input" type. Doing so provides more information to upcoming argument and result matching.
Contributor
Author
|
@swift-ci please smoke test |
hborla
approved these changes
Jan 28, 2020
xedin
commented
Jan 28, 2020
| return true; | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@hborla I think once we implement "one fix in N solutions" ambiguity handling all of the logic below could be replaced with return false; :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obsolete almost all of the logic related to re-typecheck of the
function expressionassociatedwith
ApplyExpr.