[Diagnostics] Remove obsolete FailureDiagnosis::visitIdentityExpr from CSDiag #29413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@swift-ci please smoke test |
LucianoPAlmeida
force-pushed
the
remove-visit-identity-expr-csdiag
branch
from
03e34ff to
2c7cc7b
Compare
Contributor
Author
|
Thank you for the review :) |
Member
|
@swift-ci please smoke test |
Contributor
|
@swift-ci please smoke test Linux platform |
Contributor
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea was to remove the code, see how many tests fail and maybe start working on them. But since none of the test breaks locally ¯_(ツ)_/¯, this may be obsolete? :)
cc @xedin @hborla