Re-enable asan_recover.swift test on Darwin because it should work correctly there.
#29294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test and merge |
eeckstein
approved these changes
Jan 20, 2020
Contributor
Author
|
The logs for the failures are missing. I'll just trigger again. |
Contributor
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
correctly there. To do this just disable on Linux where the test is currently broken. rdar://problem/58640751
delcypher
force-pushed
the
re_enable_58640751_darwin
branch
from
8b39404 to
c2185c2
Compare
Contributor
Author
|
Build failure is completely unrelated to this change. Rebasing and trying again. |
Contributor
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
Contributor
Author
|
The CI is very sad. The failures have nothing to do with this PR so I'm just going to land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable
asan_recover.swifttest on Darwin because it should work correctly there.correctly there.
To do this just disable on Linux where the test is currently broken.
rdar://problem/58640751