[NFC] Add an EmitSortedSIL member to SILOptions for consistency.#29210
Merged
varungandhi-apple merged 1 commit intoswiftlang:masterfrom Jan 16, 2020
varungandhi-apple:vg-update-SILOptions-struct
Merged
[NFC] Add an EmitSortedSIL member to SILOptions for consistency.#29210varungandhi-apple merged 1 commit intoswiftlang:masterfrom varungandhi-apple:vg-update-SILOptions-struct
varungandhi-apple merged 1 commit intoswiftlang:masterfrom
varungandhi-apple:vg-update-SILOptions-struct
Conversation
It is a bit strange to have the FrontendOptions being used in writeSIL instead of SILOptions, so this PR fixes that.
Contributor
Author
|
@swift-ci please smoke test |
Contributor
|
Unless I missed it, I think you also need to remove line 70 of ArgsToFrontendOptionsConverter. |
Contributor
Author
|
I don't think that should be removed. I didn't remove the flag from |
Contributor
Author
|
@swift-ci please clean smoke test Linux platform |
CodaFi
approved these changes
Jan 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a bit strange to have the FrontendOptions being used in writeSIL
instead of SILOptions, so this PR fixes that.