Re-land parsing and printing for Clang function types.#29049
Merged
varungandhi-apple merged 1 commit intoJan 8, 2020
Merged
Conversation
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
cc @compnerd |
Member
|
@swift-ci please test Windows platform |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit e805fe4, which reverted the change earlier. The problem was caused due to a simultaneous change to some code by the PR with parsing and printing for Clang function types (#28737) and the PR which introduced Located<T> (#28643). This commit also includes a small change to make sure the intersecting region is fixed: the change is limited to using the fields of Located<T> in the `tryParseClangType` lambda.
Contributor
Author
|
@swift-ci please test Windows platform |
Contributor
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci please test Windows platform |
1 similar comment
Contributor
Author
|
@swift-ci please test Windows platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e805fe4, which reverted
the change earlier. The problem was caused due to a simultaneous change to some
code by the PR with parsing and printing for Clang function types (#28737)
and the PR which introduced Located (#28643).
This commit also includes 2 small changes:
is fixed: the change is limited to using the fields of Located in the
tryParseClangTypelambda.full-convention.swifthas been updated to useInt32instead ofIntto avoid differences between platforms (Inttranslates tolongon Linux/macOS butlong longon Windows).