[AST] Consolidate Obj-C types on ASTContext#28128
Merged
hamishknight merged 3 commits intoswiftlang:masterfrom Nov 7, 2019
Merged
[AST] Consolidate Obj-C types on ASTContext#28128hamishknight merged 3 commits intoswiftlang:masterfrom
hamishknight merged 3 commits intoswiftlang:masterfrom
Conversation
This commit moves the getNSObjectType and getObjCSelectorType methods from TypeChecker onto ASTContext. In addition, it moves the FOR_KNOWN_FOUNDATION_TYPES macro into a separate file to define each of the Obj-C type decls we want to have access to.
Contributor
Author
|
@swift-ci please smoke test |
CodaFi
approved these changes
Nov 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
getNSObjectTypeandgetObjCSelectorTypemethods fromTypeCheckerontoASTContext. In addition, it moves theFOR_KNOWN_FOUNDATION_TYPESmacro into a separate KnownObjCTypes.def file to define each of the Obj-C type decls we want to have access to.Lastly, in the spirit of #27195, it defines variants of the
getXXXDeclaccessors that return the types.