[TF] Make expandingShape take [Int] or Int... #24191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
approved these changes
Apr 20, 2019
Contributor
rxwei
left a comment
rxwei
left a comment
There was a problem hiding this comment.
Thanks Sylvain!
We are in the process of moving all Tensor APIs out of the compiler repo into the deep learning library (tensorflow/swift-apis#70). That will make it easier and faster to develop and test!
Contributor
|
@swift-ci please test tensorflow |
Author
|
Had missed that, will make new PRs there directly. |
This was referenced Apr 25, 2019
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #24164, this PR adds functionality for
Tensor.expandingShape, make it support [Int] or Int... (like its counterpartTensor.squeezingShape).I also added a test for both those functions (none were directly tested), and the gradient test is passing.