Update WindowsBuild.md #22513
Merged
Update WindowsBuild.md #22513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deal with different python versions being installed. GYB is python2 only and breaks with python 3.x. Ensure that we pick up python 2.7 when building (this is the version vended by Visual Studio and is the stable 2.x series release).
Member
Author
|
CC: @gwynne |
Member
Author
|
@swift-ci please smoke test |
Contributor
|
Visual Studio also vends 64-bit Python 2.7 at |
Member
Author
|
@gwynne ... don't think that the 32-bit vs 64-bit matters here, its used for gyb |
Contributor
|
@compnerd Oh how well I know! But I was thinking more of configurations where only the 64-bit version is installed (such as mine). |
Member
Author
|
Okay, I think that adding that as a follow up is reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with different python versions being installed. GYB is python2 only and breaks with python 3.x. Ensure that we pick up python 2.7 when building (this is the version vended by Visual Studio and is the stable 2.x series release).
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.