Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt a search path for bridgeable types in component modules (no longer just in Foundation) #21234

Closed
wants to merge 5 commits into from
Closed

Adopt a search path for bridgeable types in component modules (no longer just in Foundation) #21234

wants to merge 5 commits into from

Conversation

millenomi
Copy link
Contributor

Required for the work in swiftlang/swift-corelibs-foundation#1799.

@millenomi millenomi mentioned this pull request Dec 12, 2018
Closed
@jrose-apple
Copy link
Contributor

Should we guard this under !canImport(Darwin), so it doesn't get used by accident on a system that doesn't have Swift Foundation?

@millenomi millenomi force-pushed the swift-corelibs-foundation-split-soil branch from 6a39dc0 to b329ea7 Compare December 17, 2018 21:47
@millenomi
Copy link
Contributor Author

@jrose-apple All this code currently runs on all OSes, including where Swift Foundation is not available. As a reminder, Swift Foundation may be available and must be functional on Darwin as we target that platform for test purposes only (which is why all the search paths I introduce in this patch include the Swift-prefixed spelling of the Foundation modules to search in).

@millenomi
Copy link
Contributor Author

cfr. swiftlang/swift-corelibs-foundation#1799

@millenomi millenomi force-pushed the swift-corelibs-foundation-split-soil branch from ee47638 to d6955db Compare January 3, 2019 00:20
@millenomi
Copy link
Contributor Author

@swift-ci please smoke test

@millenomi
Copy link
Contributor Author

The Linux crash is expected without the SCF changes; the macOS pass was not. Trying to build a toolchain with this so that I can try building SCF on Darwin and reproduce the crash I'm seeing in swiftlang/swift-corelibs-foundation#1799

@millenomi millenomi force-pushed the swift-corelibs-foundation-split-soil branch from d6955db to 3793e28 Compare January 8, 2019 20:44
@millenomi millenomi mentioned this pull request Jan 8, 2019
Closed
@millenomi millenomi changed the title [DNM] Change the module name for Foundation splitting Adopt a search path for bridgeable types in component modules (no longer just in Foundation) Jan 8, 2019
@millenomi
Copy link
Contributor Author

Please test with the following:
apple/swift-clang#245
swiftlang/swift-package-manager#1914
swiftlang/swift-corelibs-foundation#1799

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jan 8, 2019

Build failed
Swift Test OS X Platform
Git Sha - 6a39dc047993a6e61c12f8ee9cfb1b4b4a36a22a

@swift-ci
Copy link
Contributor

swift-ci commented Jan 8, 2019

Build failed
Swift Test Linux Platform
Git Sha - 6a39dc047993a6e61c12f8ee9cfb1b4b4a36a22a

@millenomi
Copy link
Contributor Author

Please test with the following:
apple/swift-clang#245
swiftlang/swift-package-manager#1914
swiftlang/swift-corelibs-foundation#1799
apple/swift-lldb#1187

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jan 9, 2019

Build failed
Swift Test Linux Platform
Git Sha - 3793e288ea748639328b42f29c22b377c5809d8d

@millenomi millenomi mentioned this pull request Jan 10, 2019
Closed
@millenomi millenomi force-pushed the swift-corelibs-foundation-split-soil branch from 3793e28 to 3bf46ab Compare January 11, 2019 18:52
@millenomi millenomi force-pushed the swift-corelibs-foundation-split-soil branch from 3bf46ab to 6b8f910 Compare January 22, 2019 17:50
@shahmishal
Copy link
Member

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

  • How to change the base branch: (Link)
  • More detail about the branch update: (Link)

@shahmishal shahmishal closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@millenomi @jrose-apple @swift-ci @shahmishal