Skip to content

Don't change the token kind of yield until we commit to a statement. - #18179

Merged
rjmccall merged 1 commit into
swiftlang:masterfrom
rjmccall:yield-keyword-kind
Jul 24, 2018
Merged

rjmccall merged 1 commit into
swiftlang:masterfrom
rjmccall:yield-keyword-kind

Conversation

@rjmccall

Copy link
Copy Markdown
Contributor

Per Rintaro's code review in #18156.

@rjmccall

Copy link
Copy Markdown
Contributor Author

@swift-ci Please smoke test.

@rintaro rintaro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@rjmccall

Copy link
Copy Markdown
Contributor Author

@swift-ci Please smoke test OS X.

@rjmccall

Copy link
Copy Markdown
Contributor Author

@swift-ci Please test OS X.

@swift-ci

Copy link
Copy Markdown
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a41ccb2

@rjmccall

Copy link
Copy Markdown
Contributor Author

(Mishal killed the full build because I'd only started it as part of flailing against the bots, which were down.)

@rjmccall
rjmccall merged commit 096b62d into swiftlang:master Jul 24, 2018
@rjmccall
rjmccall deleted the yield-keyword-kind branch July 24, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants