Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail createDirectory if directory is created concurrently by another process #490

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 28, 2024

I hit such a race in SourceKit-LSP tests when SwiftPM is initializing the .index-build directory and IndexStore-DB is concurrently creating its database in .index-build/arm64-apple-macosx/debug/index/db/.

@ahoppen
Copy link
Member Author

ahoppen commented Oct 28, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Oct 28, 2024

@swift-ci Please test Windows

2 similar comments
@ahoppen
Copy link
Member Author

ahoppen commented Oct 28, 2024

@swift-ci Please test Windows

@ahoppen
Copy link
Member Author

ahoppen commented Oct 29, 2024

@swift-ci Please test Windows

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@ahoppen ahoppen merged commit 4074f4d into swiftlang:main Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants