[5.9] Add hasAttribute to FileSystem
#412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new function returns `true` if a given path has a quarantine attribute applied if when file system supports this attribute, and returns `false` if such attribute is not applied or it isn't supported.
MaxDesiatov
requested review from
aciidgh,
abertelrud and
neonichu
as code owners
MaxDesiatov
changed the title
hasQuarantineAttribute to FileSystemhasQuarantineAttribute to FileSystem
|
@swift-ci test |
compnerd
reviewed
Apr 21, 2023
|
@swift-ci test macos |
MaxDesiatov
changed the title
hasQuarantineAttribute to FileSystemhasAttribute to FileSystem
|
@swift-ci test |
|
@swift-ci test windows |
compnerd
approved these changes
Apr 21, 2023
neonichu
approved these changes
Apr 21, 2023
|
@swift-ci test |
|
@swift-ci test windows |
|
Currently blocked by #419 |
|
@swift-ci test |
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #414.
Motivation
Detecting whether a given absolute path is quarantined is required for giving an actionable error message to SwiftPM users in case a Swift SDK bundle is quarantined.
Modifications
This new function returns
trueif a given path has an attribute applied when the file system supports this attribute, and returnsfalseif such attribute is not applied or it isn't supported.Risk
For TSC itself it's an additive change with low to no risk, as updated protocol requirement has a default implementation. This new requirement is also "standalone" as it isn't used in any other TSC function, so it doesn't have any impact on existing code.
rdar://107392863