-
Notifications
You must be signed in to change notification settings - Fork 129
Show the number of test cases that ran at the end of a test #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
14184b1
a1f7b4b
928f67b
2a796ec
16a997e
ea309da
4592e06
4cf3306
46d4910
701506c
9616b98
8f61da7
5c52756
a5bac97
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -146,6 +146,23 @@ extension Event.HumanReadableOutputRecorder { | |
|
|
||
| return (errorIssueCount, warningIssueCount, knownIssueCount, totalIssueCount, description) | ||
| } | ||
|
|
||
| /// Returns a formatted string describing the number of arguments in a test, based on verbosity level. | ||
| /// | ||
| /// - Parameters: | ||
| /// - test: to get the number of `testCases` out of a ``Test``. | ||
| /// - verbose: If the level is very verbose, a detailed description is returned. | ||
| /// | ||
| /// - Returns: A string describing the number of test cases in the test, or an empty string if it's not very verbose level. | ||
| /// | ||
| private func _includeNumberOfTestCasesIfNeeded(for test: Test, verbose: Int) -> String { | ||
| if verbose == 2 && !test.isSuite { // very verbose | ||
| let testCasesCount = test.testCases?.count(where: { _ in true }) ?? 0 | ||
|
||
| return" with \(testCasesCount) \(testCasesCount > 1 ? "test cases" : "test case")" | ||
| } | ||
| return "" | ||
| } | ||
|
|
||
|
||
| } | ||
|
|
||
| /// Generate a title for the specified test (either "Test" or "Suite"), | ||
|
|
@@ -370,14 +387,14 @@ extension Event.HumanReadableOutputRecorder { | |
| CollectionOfOne( | ||
| Message( | ||
| symbol: .fail, | ||
| stringValue: "\(_capitalizedTitle(for: test)) \(testName) failed after \(duration)\(issues.description)." | ||
| stringValue: "\(_capitalizedTitle(for: test)) \(testName)\(_includeNumberOfTestCasesIfNeeded(for: test, verbose: verbosity)) failed after \(duration)\(issues.description)." | ||
| ) | ||
| ) + _formattedComments(for: test) | ||
| } else { | ||
| [ | ||
| Message( | ||
| symbol: .pass(knownIssueCount: issues.knownIssueCount), | ||
| stringValue: "\(_capitalizedTitle(for: test)) \(testName) passed after \(duration)\(issues.description)." | ||
| stringValue: "\(_capitalizedTitle(for: test)) \(testName)\(_includeNumberOfTestCasesIfNeeded(for: test, verbose: verbosity)) passed after \(duration)\(issues.description)." | ||
| ) | ||
| ] | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -178,6 +178,45 @@ struct EventRecorderTests { | |
| .first != nil | ||
| ) | ||
| } | ||
|
|
||
| @available(_regexAPI, *) | ||
| @Test( | ||
| "number of arguments based on verbosity level at the end of test run", | ||
|
||
| arguments: [ | ||
| ("f()", #".* Test f\(\) failed after .*"# , 0), | ||
| ("f()", #".* Test f\(\) with 1 test case failed after .*"# , 2), | ||
| ("d(_:)", #".* Test d\(_:\) with .+ test cases passed after.*"# , 2), | ||
| ("PredictablyFailingTests", #".* Suite PredictablyFailingTests failed after .*"# , 1), | ||
| ("PredictablyFailingTests", #".* Suite PredictablyFailingTests failed after .*"# , 2), | ||
| ] | ||
| ) | ||
| func numberOfArgumentsAtTheEndOfTests(testName: String, expectedPattern: String, verbosity: Int) async throws { | ||
| let stream = Stream() | ||
|
|
||
| var configuration = Configuration() | ||
| let eventRecorder = Event.ConsoleOutputRecorder(writingUsing: stream.write) | ||
| configuration.eventHandler = { event, context in | ||
| eventRecorder.record(event, in: context) | ||
| } | ||
| configuration.verbosity = verbosity | ||
|
|
||
| await runTest(for: PredictablyFailingTests.self, configuration: configuration) | ||
|
|
||
| let buffer = stream.buffer.rawValue | ||
| if testsWithSignificantIOAreEnabled { | ||
| print(buffer, terminator: "") | ||
| } | ||
|
|
||
| let aurgmentRegex = try Regex(expectedPattern) | ||
|
|
||
| #expect( | ||
| (try buffer | ||
| .split(whereSeparator: \.isNewline) | ||
| .compactMap(aurgmentRegex.wholeMatch(in:)) | ||
| .first) != nil | ||
| ) | ||
| } | ||
|
|
||
|
|
||
| @available(_regexAPI, *) | ||
| @Test( | ||
|
|
@@ -536,6 +575,11 @@ struct EventRecorderTests { | |
| #expect(Bool(false)) | ||
| } | ||
| } | ||
|
|
||
| @Test(.hidden, arguments: [1, 2, 3]) | ||
| func d(_ arg: Int) { | ||
| #expect(arg > 0) | ||
| } | ||
|
|
||
| @Test(.hidden) func g() { | ||
| #expect(Bool(false)) | ||
|
|
@@ -566,3 +610,4 @@ struct EventRecorderTests { | |
| } | ||
| } | ||
| } | ||
|
|
||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably mean
>= 2, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if you want to count test cases, you should use
test.isParameterized, not!test.isSuite, since it doesn't make sense to count test cases for a non-parameterized test function either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated