Change archive format for directories to .zip and add iOS/etc. support. #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
grynspan
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
stmontgomery and
suzannaratcliff
as code owners
Contributor
Author
|
@kperryua I can't add you as a reviewer for whatever reason. Hi. |
compnerd
reviewed
Nov 15, 2024
Sources/Overlays/_Testing_Foundation/Attachments/Attachment+URL.swift
Outdated
Show resolved
Hide resolved
compnerd
approved these changes
Nov 16, 2024
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Seems mostly reasonable - except for this spawning processes under SWT_NO_PROCESS_SPAWNING 😂
Contributor
Author
As discussed elsewhere, there's a |
Contributor
Author
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/zip-directories
branch
from
d7ca88f to
708811a
Compare
briancroom
approved these changes
Nov 21, 2024
Contributor
Author
|
@swift-ci test |
This PR switches from .tar.gz as the preferred archive format for compressed directories to .zip and uses `NSFileCoordinator` on Darwin to enable support for iOS, watchOS, tvOS, and visionOS.
grynspan
force-pushed
the
jgrynspan/zip-directories
branch
from
708811a to
6cebbed
Compare
Contributor
Author
|
@swift-ci test |
stmontgomery
reviewed
Dec 5, 2024
Sources/Overlays/_Testing_Foundation/Attachments/Attachment+URL.swift
Outdated
Show resolved
Hide resolved
stmontgomery
reviewed
Dec 5, 2024
stmontgomery
approved these changes
Dec 5, 2024
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from .tar.gz as the preferred archive format for compressed directories to .zip and uses
NSFileCoordinatoron Darwin to enable support for iOS, watchOS, tvOS, and visionOS.This feature remains experimental.
Checklist: