Ensure the Bool overload of __checkBinaryOperation() is still preferred.
#797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferred. We noticed that in some conditions, boolean arguments to `#expect()` would compile to use the _optional_ overload of `__checkBinaryOperation()`, which would result in a pass when a failure should have occurred because the boolean value never evaluated to `nil`. This PR should resolve that issue. Resolves rdar://138964155.
grynspan
added
bug
grynspan
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
stmontgomery and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows |
briancroom
approved these changes
Nov 3, 2024
Contributor
briancroom
left a comment
briancroom
left a comment
There was a problem hiding this comment.
Thanks for the fix and new test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that in some conditions, boolean arguments to
#expect()would compile to use the optional overload of__checkBinaryOperation(), which would result in a pass when a failure should have occurred because the boolean value never evaluated tonil. This PR should resolve that issue.Resolves rdar://138964155.
Checklist: