Ensure trailing trivia is trimmed from @Suite trait expressions #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
grynspan and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci please test |
Contributor
|
Should we cherry-pick to release/6.0 and/or release/6.0.2? |
grynspan
approved these changes
Oct 21, 2024
Contributor
Author
Unclear whether it's worthwhile since I'd consider this a fairly minor bug with an easy workaround. But if anyone wants this in pre-6.1, please chime in here and we can can consider it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if a
@Suiteincludes one or more trait expression which includes trailing trivia, such as a//-style line comment, it is trimmed so that the macro expands to valid code.Resolves #777
Checklist: