Attachments! #770
Merged
Attachments! #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
grynspan
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
stmontgomery and
suzannaratcliff
as code owners
grynspan
force-pushed
the
jgrynspan/attachments
branch
from
4570404 to
fd7e89d
Compare
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
plemarquand
requested changes
Oct 22, 2024
Contributor
|
If there is no |
Contributor
Author
|
We could also try to default to some benign location like /tmp, maybe. |
grynspan
force-pushed
the
jgrynspan/attachments
branch
from
6b6d78a to
510f445
Compare
Contributor
Author
|
@swift-ci test |
grynspan
commented
Oct 23, 2024
grynspan
force-pushed
the
jgrynspan/attachments
branch
from
510f445 to
7da28f0
Compare
Contributor
Author
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/attachments
branch
from
02b30c1 to
097944b
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows |
Contributor
Author
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/attachments
branch
from
ad35d3e to
ed14512
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Linux |
Contributor
Author
|
@swift-ci test macOS |
Contributor
stmontgomery
left a comment
stmontgomery
left a comment
There was a problem hiding this comment.
Very cool! Took a deep look and left many comments/questions
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
stmontgomery
reviewed
Nov 1, 2024
stmontgomery
approved these changes
Nov 1, 2024
briancroom
reviewed
Nov 1, 2024
briancroom
reviewed
Nov 1, 2024
briancroom
approved these changes
Nov 1, 2024
tshortli
added a commit
to tshortli/swift-testing
that referenced
this pull request
Nov 2, 2024
This reverts commit bb19b2a.
This was referenced Nov 3, 2024
Merged
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Nov 9, 2024
Work in progress patch to support swift-testing attachments. Currently prints the attachments out as a report at the end of a test run. In order to leverage them we need to set the --attachment-path, which is not available on the command line so we add a configuration json file. There is still more work to do to allow the user to specify their own attachment path on a per workspace basis. This will currently only work with swiftlang/swift-testing#770 as it isn't merged yet.
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Jan 10, 2025
Work in progress patch to support swift-testing attachments. Currently prints the attachments out as a report at the end of a test run. In order to leverage them we need to set the --attachment-path, which is not available on the command line so we add a configuration json file. There is still more work to do to allow the user to specify their own attachment path on a per workspace basis. This will currently only work with swiftlang/swift-testing#770 as it isn't merged yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new experimental feature, attachments. With this feature, you can "attach" values that conform to a new
Test.Attachableprotocol to a test. With the right command-line incantation (TBD), Swift Testing will automatically write attachments to disk for you.Note
This PR does not teach Xcode or VS Code how to handle attachments produced by
Swift Testing, nor does it add the necessary command-line arguments to the
swift testcommand-line tool.This PR is one of a series that I'll be posting to build out this feature.
As always, keep in mind that symbols marked
@_spi(Experimental)are subject to change or removal without notice.Resolves #714.
Resolves rdar://88648735.
Checklist: