Propagate SkipInfo to child tasks when a test is cancelled.
#1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ensures that, when a test is cancelled, its test cases report the same `SkipInfo` structure as they are recursively cancelled. For instance: ```swift @test(arguments: [a ... z]) func foo(arg: T) throws { try Test.cancel("Message") } ``` Prior to this change, the `.testCaseCancelled` events would be posted without the user-supplied comment `"Message"` and each one would need to construct a source context by capturing a backtrace from deep within Swift Testing and the stdlib. With this change in place, said events post with the same comment and source context as is associated with the initial `.testCancelled` event.
grynspan
requested review from
briancroom,
jerryjrchen,
stmontgomery and
suzannaratcliff
as code owners
grynspan
added
enhancement
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Linux |
briancroom
reviewed
Sep 3, 2025
briancroom
reviewed
Sep 3, 2025
briancroom
reviewed
Sep 3, 2025
Contributor
Author
|
@swift-ci test |
briancroom
approved these changes
Sep 3, 2025
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that, when a test is cancelled, its test cases report the same
SkipInfostructure as they are recursively cancelled. For instance:Prior to this change, the
.testCaseCancelledevents would be posted without the user-supplied comment"Message"and each one would need to construct a source context by capturing a backtrace from deep within Swift Testing and the stdlib.With this change in place, said events post with the same comment and source context as is associated with the initial
.testCancelledevent.Checklist: