Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Allow building swift-syntax in C++ interop mode #2861

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Sep 25, 2024

  • Explanation: If swift-syntax is being built with -cxx-interoperability-mode=default, it fails because of cannot initialize a variable of type 'AtomicBool *' with an rvalue of type 'void *'. Add a cast here to fix the build issue.
  • Scope: Build of swift-syntax in C++ interop mode
  • Risk: Very low, just adding an explicit cast from void * to AtomicBool *
  • Testing: n/a
  • Issue: rdar://129252735
  • Reviewer: @bnbarham on Allow building swift-syntax in C++ interop mode #2752

If swift-syntax is being built with `-cxx-interoperability-mode=default`, it fails because of `cannot initialize a variable of type 'AtomicBool *' with an rvalue of type 'void *'`. Add a cast here to fix the build issue.

rdar://129252735
@ahoppen
Copy link
Member Author

ahoppen commented Sep 25, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 0687f71 into swiftlang:release/6.0 Sep 25, 2024
3 checks passed
@ahoppen ahoppen deleted the 6.0/allow-build-in-cxx-interop-mode branch September 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants