Return a keyPathInParent for syntax collections
#1921
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
kimdv
approved these changes
Jul 18, 2023
ahoppen
force-pushed
the
ahoppen/collection-key-path
branch
from
1e4dbc7 to
4fba178
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
1 similar comment
Contributor
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test |
Contributor
|
@swift-ci please test Windows |
Contributor
|
Windows failure does actually look related unfortunately. Though more like a compiler bug than an issue with this PR 😅 |
bnbarham
approved these changes
Jul 21, 2023
Member
Author
|
This is triggering SIL verification failures on Windows (swiftlang/swift#67676). Marking as draft until that’s fixed |
Previously, `keyPathInParent` returned `nil` for nodes that occurred in `SyntaxCollection`s. Return a subscript-based key path instead. rdar://111944659
ahoppen
force-pushed
the
ahoppen/collection-key-path
branch
from
4fba178 to
693b32f
Compare
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
keyPathInParentreturnednilfor nodes that occurred inSyntaxCollections. Return a subscript-based key path instead.rdar://111944659