Skip to content

Allow cross-PR testing for GitHub actions#9820

Merged
ahoppen merged 1 commit intoswiftlang:mainfrom
ahoppen:github-actions-cross-pr
Mar 23, 2026
Merged

Allow cross-PR testing for GitHub actions#9820
ahoppen merged 1 commit intoswiftlang:mainfrom
ahoppen:github-actions-cross-pr

Conversation

@ahoppen
Copy link
Copy Markdown
Member

@ahoppen ahoppen commented Mar 17, 2026

@ahoppen
Copy link
Copy Markdown
Member Author

ahoppen commented Mar 17, 2026

@swift-ci Please test

Copy link
Copy Markdown
Contributor

@bkhouri bkhouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great initiative. However, unless I missed something, when I browsed the https://github.com/swiftlang/github-workflows repository code base, setting enable_cross_pr_testing to true will only clone repositories, but the swift build does not actually use them.

Do we need to so something else to ensure the build command uses the "linked PRs"?

@ahoppen
Copy link
Copy Markdown
Member Author

ahoppen commented Mar 23, 2026

setting enable_cross_pr_testing to true will only clone repositories, but the swift build does not actually use them.

It does by setting a package mirror to point to the local checkout, which has the referenced PR merged: https://github.com/swiftlang/github-workflows/blob/61db6917df4ec2ddeeb493757e2d1effd46af855/.github/workflows/scripts/cross-pr-checkout.swift#L225-L234

@ahoppen
Copy link
Copy Markdown
Member Author

ahoppen commented Mar 23, 2026

@swift-ci Please test macOS

@ahoppen ahoppen merged commit b551794 into swiftlang:main Mar 23, 2026
60 of 61 checks passed
@ahoppen ahoppen deleted the github-actions-cross-pr branch March 23, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants