Use --swift-sdk selector as SDK name for Wasm platform#9545
Open
kateinoigakukun wants to merge 1 commit intoswiftlang:mainfrom
Open
Use --swift-sdk selector as SDK name for Wasm platform#9545kateinoigakukun wants to merge 1 commit intoswiftlang:mainfrom
--swift-sdk selector as SDK name for Wasm platform#9545kateinoigakukun wants to merge 1 commit intoswiftlang:mainfrom
Conversation
kateinoigakukun
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
Contributor
|
@cmcgee1024 already has some changes up in #9527 which will be restructuring this code substantially in conjunction with API changes on the Swift Build side. |
Contributor
|
@swift-ci test |
Contributor
|
@swift-ci test macos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
--swift-sdkselector as SDK name for Wasm platformMotivation:
The expected SDK name for Wasm platform support in SwiftBuild is always Swift SDK id, not
"webassembly", so passing always passing"webassembly"makes SwiftBuild unable to resolve a particular Swift SDK.Close #9364
Modifications:
Propagate
--swift-sdkvalue as SDK name to SwiftBuild for Wasm targets.Result:
With this change and swiftlang/swift-build#998, we can build a simple hello world package with
--build-system swiftbuildwith Swift SDK for Wasm.