Revert "Change AsyncProcess stdout/err reads to 4096 instead of Int.max (#9408)"#9535
Merged
Revert "Change AsyncProcess stdout/err reads to 4096 instead of Int.max (#9408)"#9535
Conversation
meg-gupta
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
|
@meg-gupta Could you add a description describing the cause of the revert? |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test macOS platform (self hosted) |
Contributor
Author
|
@swift-ci test windows platform |
Contributor
Author
|
@swift-ci test macOS platform |
1 similar comment
Contributor
Author
|
@swift-ci test macOS platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am reverting this since it seems like a probable cause for timeouts on sourcekit-lsp tests on windows. Example: https://ci-external.swift.org/job/swift-PR-windows/49259/console