Add tags to swift-testing tests withKnownIssues #9313
+733
−495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
requested review from
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
rconnell9 and
shawnhyam
as code owners
|
@swift-ci test |
owenv
reviewed
Oct 30, 2025
| buildSystem: BuildSystemProvider.Kind, | ||
| configuration: BuildConfiguration, | ||
| ) async throws { | ||
| try await withKnownIssue(isIntermittent: true) { |
There was a problem hiding this comment.
Should we test dropping this in CI? (maybe in a different PR)
owenv
approved these changes
Oct 30, 2025
kcieplak
approved these changes
Oct 30, 2025
jakepetroules
approved these changes
Oct 30, 2025
Augment Swift Testing test that has "withKnownIssues" with tags. Also, augment tests to run against the SwiftBuild and Native build system, in addition to the debug and release build configuraitons. Relates to: swiftlang#9283
bkhouri
force-pushed
the
t/main/gh9283_add_tags
branch
from
bcd662b to
7a910c7
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
The following tests in Windows Platform Smoke test pipeline failed This failure is unrelated to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment Swift Testing test that has "withKnownIssues" with tags.
Also, augment tests to run against the SwiftBuild and Native build system, in addition to the debug and release build configuraitons.
Relates to: #9283