Disable check for unsafe flags. #8896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in the Swift forums below, a number of projects require the use of "unsafe" flags. A common example is the use of absolute header include paths set via an environment variable that project consumers agree to use. As such, the flags can be safely used under those circumstances. This change disables the one line that was doing the check. We will further study the issue and come up with other mechanisms to ensure the challenges some flags have on quality of the package ecosystem are mitigated.
dschaefer2
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
jakepetroules,
owenv,
plemarquand and
shawnhyam
as code owners
|
@swift-ci please test |
ktoso
approved these changes
Jul 4, 2025
@dschaefer2 Could you please share the forum post? |
Oops, forgot to do that in the description. Fixed. |
jdberry
reviewed
Jul 5, 2025
|
@swift-ci please test Windows |
|
@swift-ci please test self hosted windows |
bripeticca
approved these changes
Jul 9, 2025
dschaefer2
added a commit
to dschaefer2/swift-package-manager
that referenced
this pull request
Jul 9, 2025
As discussed in the Swift forums below, a number of projects require the use of "unsafe" flags. A common example is the use of absolute header include paths set via an environment variable that project consumers agree to use. As such, the flags can be safely used under those circumstances. This change disables the one line that was doing the check. We will further study the issue and come up with other mechanisms to ensure the challenges some flags have on quality of the package ecosystem are mitigated. https://forums.swift.org/t/pitch-disable-checks-for-unsafe-flags-in-swiftpm/80698
dschaefer2
added a commit
that referenced
this pull request
Jul 17, 2025
Cherry-pick #8896 As discussed in the Swift forums below, a number of projects require the use of "unsafe" flags. A common example is the use of absolute header include paths set via an environment variable that project consumers agree to use. As such, the flags can be safely used under those circumstances. This change disables the one line that was doing the check. We will further study the issue and come up with other mechanisms to ensure the challenges some flags have on quality of the package ecosystem are mitigated. https://forums.swift.org/t/pitch-disable-checks-for-unsafe-flags-in-swiftpm/80698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the Swift forums below, a number of projects require the use of "unsafe" flags. A common example is the use of absolute header include paths set via an environment variable that project consumers agree to use. As such, the flags can be safely used under those circumstances.
This change disables the one line that was doing the check.
We will further study the issue and come up with other mechanisms to ensure the challenges some flags have on quality of the package ecosystem are mitigated.
https://forums.swift.org/t/pitch-disable-checks-for-unsafe-flags-in-swiftpm/80698