Cleanup addition of swift-syntax #7505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
bnbarham
force-pushed
the
swift-syntaxify-round-2
branch
from
b12b5c4 to
1b97c6a
Compare
Contributor
Author
|
@swift-ci please test |
bnbarham
force-pushed
the
swift-syntaxify-round-2
branch
from
1b97c6a to
034b1c9
Compare
Contributor
Author
|
@swift-ci please test |
bnbarham
force-pushed
the
swift-syntaxify-round-2
branch
from
034b1c9 to
4fc925f
Compare
Contributor
Author
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please clean test |
Contributor
Author
|
@swift-ci please clean test Windows platform |
1 similar comment
Contributor
Author
|
@swift-ci please clean test Windows platform |
bnbarham
force-pushed
the
swift-syntaxify-round-2
branch
from
41c0836 to
b6ad32e
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
|
@swift-ci test windows |
Member
|
@swift-ci please test Windows |
This was referenced Apr 27, 2024
DougGregor
approved these changes
Apr 27, 2024
Member
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
This seems to be passing everywhere, woo-hoo!
Member
|
Just waiting on swiftlang/swift-syntax#2628 to merge first |
ahoppen
pushed a commit
to ahoppen/swift-package-manager
that referenced
this pull request
May 2, 2024
ahoppen
added a commit
that referenced
this pull request
May 3, 2024
- **Explanation**: Cherry-pick the following to PRs which are companions of swiftlang/sourcekit-lsp#1213 - #7505 - #7492 - **Scope**: CMake build and SourceKit-LSP API - **Risk**: Low, the SourceKit-LSP API is only used by SourceKit-LSP and the CMake build changes will all be caught at build-time - **Testing**: n/a - **Issue**: n/a - **Reviewer**: @DougGregor and @MaxDesiatov on #7505 and #7492 --------- Co-authored-by: Ben Barham <[email protected]>
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.