[Build] Fix up the cmake build after swift-syntax was added #7502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Doesn't FetchContent when it isn't available right now, but we don't fetch any of the other required dependencies either. Can fix that when we fix them all.
DougGregor
approved these changes
Apr 25, 2024
Member
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
This definitely looks simpler
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
I forgot we bootstrap with CMake even outside of Windows :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't FetchContent when it isn't available right now, but we don't fetch any of the other required dependencies either. Can fix that when we fix them all.