Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cxx-interop] pass the C++ language standard to Clang importer in Swi… #6652

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jun 14, 2023

…ft when C++ interoperability is enabled (#6649)

Fixes #6565

(cherry picked from commit cefff2b)

  • Explanation:
    When C++ interoperability is enabled, Swift can import Clang modules that have C++. C++ targets in SPM can use languages standards like C++20, which could be incompatible with the default C++ language standard used by Swift in the Clang importer. For that reason, if the C++ language standard is specified in the package manifest, SwiftPM should pass it when C++ interoperability is enabled to the Swift compiler.
  • Scope: Computing build settings for an SPM target.
  • Risk: Low. Only affects C++ interoperability enabled targets.
  • Testing: SwiftPM unit tests.
  • PR: [cxx-interop] pass the C++ language standard to Clang importer in Swi… #6649

…ft when C++ interoperability is enabled (swiftlang#6649)

Fixes swiftlang#6565

(cherry picked from commit cefff2b)
@hyp hyp added the swift 5.9 This PR targets the 5.9 branch label Jun 14, 2023
@hyp
Copy link
Contributor Author

hyp commented Jun 14, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Jun 14, 2023

@swift-ci please test windows platform

@hyp
Copy link
Contributor Author

hyp commented Jun 14, 2023

@swift-ci please test

@neonichu
Copy link
Contributor

@swift-ci please smoke test

@hyp hyp merged commit 49ec9c6 into swiftlang:release/5.9 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
swift 5.9 This PR targets the 5.9 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants