[NFC] PkgConfigTests: use some FileSystem instead of existentials
#6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small optimization that avoids the use of boxing for existentials.
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
|
swiftlang/swift-tools-support-core#401 |
|
swiftlang/swift-tools-support-core#401 @swift-ci smoke test |
|
The Linux self-hosted failure is due to lack of cross-repo testing support, and macOS failure looks like a compiler bug in the older version of Swift we still have on CI? This isn't reproducible with either Swift 5.7 or 5.8 on macOS. |
|
Maybe a new bug? macOS smoke tests should be using the compiler built from |
|
I see in the smoke test job it's passing the Xcode compiler explicitly during bootstrapping: Should we modify the bootstrapping script to use the freshly built compiler instead? |
I think so, yes |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small optimization that avoids the use of boxing for existentials. Without it applying swiftlang/swift-tools-support-core#401 to TSCBasic dependency and its
localFileSystemdeclaration will break compilation for this test.