`lld-link: error: undefined symbol: $s8SwiftCOM8IUnknownCMn`

[hjyamauchi]

Description

Building https://github.com/compnerd/swift-win32 with spm on the Windows toolchain built at the main-branch tip-of-tree since yesterday (11/07/2024) fails to link

lld-link: error: undefined symbol: $s8SwiftCOM17IWICBitmapDecoderCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\Image.swift.o:($s10SwiftWin325ImageC4size12CoreGraphics4SizeVvgTq)

lld-link: error: undefined symbol: $s8SwiftCOM21IWICBitmapFrameDecodeCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\Image.swift.o:($s10SwiftWin325ImageC4size12CoreGraphics4SizeVvgTq)

lld-link: error: undefined symbol: $s8SwiftCOM19IWICFormatConverterCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\Image.swift.o:($s10SwiftWin325ImageC4size12CoreGraphics4SizeVvgTq)

Reverting the commit #8049 seems to make this error go away.

Reproduction

1. Build the Windows toolchain built at the main-branch tip-of-tree since yesterday (11/07/2024).
2. git clone https://github.com/compnerd/swift-win32
3. cd swift-win32 && swift build

Expected behavior

A successful build with no link errors

Environment

For example, build the windows toolchain at the following commits

swift_argument_parser_revision=0fbc8848e389af3bb55c182bc19ca9d5dc2f255b
swift_asn1_revision=12c24ff59d541e5ef15116095445ce72b85cd0c6
swift_atomics_revision=cd142fd2f64be2100422d658e7411e39489da985
swift_certificates_revision=01d7664523af5c169f26038f1e5d444ce47ae5ff
swift_collections_revision=3d2dc41a01f9e49d84f0a3925fb858bed64f702d
swift_corelibs_libdispatch_revision=0d6718284b6511030c859cefc97b63f7bcdd567c
swift_crypto_revision=629f0b679d0fd0a6ae823d7f750b9ab032c00b80
swift_nio_revision=6d30ec4738389e875f1a22345463468d4d581063
swift_system_revision=f9266c85189c2751589a50ea5aec72799797e471
ds2_revision=d63dfb9c84057fd60ddfe81100f93ebab3c59c03
swift_build_revision=e2e1a79848ae6287244431e613d9121ed16a28a4
swift_win32_revision=45a9e4e83cef6ffeef0509c34452d648e88d8eb6
curl_revision=83bedbd730d62b83744cc26fa0433d3f6e2e4cd6
libxml2_revision=2b998a4ffbdfea04fc6a620721abc690a15743af
yams_revision=0d9ee7ea8c4ebd4a489ad7a73d5c6cad55d6fed3
zlib_revision=51b7f2abdade71cd9bb0e7a373ef2610ec6f9daf
mimalloc_revision=8c532c32c3c96e5ba1f2283e032f69ead8add00f
indexstore_db_revision=fbbde36c6477283d2a49686aea5cc5b3cf47edc7
llvm_project_revision=ef32f2502839b9d4e1342108f2442173ee300191
sourcekit_lsp_revision=e73e8b798466aa8161ceb687ad2be092face8176
swift_revision=88c2269e693227ec0a88df339a011e5c32ddb4c2
swift_cmark_revision=b022b08312decdc46585e0b3440d97f6f22ef703
swift_corelibs_foundation_revision=21b3196b33a64d53a0989881fc9a486227b4a316
swift_corelibs_xctest_revision=a356762923b1ed2d4dcc8799a934bd87b54204af
swift_docc_revision=784ba5801b4bd8b092bff695a288b4053ce53c65
swift_docc_plugin_revision=3303b164430d9a7055ba484c8ead67a52f7b74f6
swift_docc_render_revision=01e5673f2e5acf052c25b7791425c7ceb7ea88fa
swift_docc_render_artifact_revision=88815688627177b9716a01ca41da19397bd30e47
swift_docc_symbolkit_revision=96bce1cfad4f4d7e265c1eb46729ebf8a7695f4b
swift_driver_revision=7e74ff66f9b2a4a97879ada7b4d45edea704b32d
swift_experimental_string_processing_revision=ed6f29f0d9512c7fef0a6ef92de2ebe9ce5d5520
swift_format_revision=c1e7b6e4e1a2b2e36609aace429d6808369986bf
swift_foundation_revision=79bd7e52e4876605fe26fccb5fb5bfc57041f191
swift_foundation_icu_revision=7e255a994ec26a08214f8fea2fdaf60b296e1f22
swift_installer_scripts_revision=0724f4767c3b7c88cd4d7a86f7118dd7dc1115c6
swift_llbuild_revision=da9efe6610220e77635a7444d88d901b328ab4a2
swift_lmdb_revision=c42582487fe84f72a4d417dd2d8493757bd4d072
swift_markdown_revision=90a8e2ec3d814093435b76c5e87917bd81785fd4
swift_package_manager_revision=f34907c51eb5f3a9868ab727646d28b7a2b556a1
swift_syntax_revision=8ed764599739d259ef9c86c14850285f1e93068c
swift_testing_revision=e2528b9b8bf7a198818c7c09172696ce30a03ee7
swift_toolchain_sqlite_revision=bb8321a7eea3830af401a1501c7c8cc27ded6793
swift_tools_support_core_revision=4074f4db0971328c441fc1621c673937b9ca3b08

Additional information

The entire build error message:

C:\Users\hiroshi>git clone https://github.com/compnerd/swift-win32
Cloning into 'swift-win32'...
remote: Enumerating objects: 5826, done.
remote: Counting objects: 100% (349/349), done.
remote: Compressing objects: 100% (232/232), done.
remote: Total 5826 (delta 137), reused 235 (delta 112), pack-reused 5477 (from 1)
Receiving objects: 100% (5826/5826), 1.50 MiB | 6.90 MiB/s, done.
Resolving deltas: 100% (3644/3644), done.

C:\Users\hiroshi>cd swift-win32

C:\Users\hiroshi\swift-win32>swift build
Fetching https://github.com/compnerd/cassowary.git
Fetched https://github.com/compnerd/cassowary.git from cache (0.84s)
Fetching https://github.com/compnerd/swift-com.git
Fetched https://github.com/compnerd/swift-com.git from cache (0.91s)
Fetching https://github.com/apple/swift-log.git
Fetching https://github.com/apple/swift-collections.git from cache
warning: 'swift-collections': skipping cache due to an error: Couldn’t fetch updates from remote repositories:
    fatal: not a git repository (or any of the parent directories): .git
Fetched https://github.com/apple/swift-log.git from cache (1.01s)
Fetched https://github.com/apple/swift-collections.git from cache (3.00s)
Computing version for https://github.com/apple/swift-collections.git
Computed https://github.com/apple/swift-collections.git at 1.0.6 (3.83s)
Computing version for https://github.com/apple/swift-log.git
Computed https://github.com/apple/swift-log.git at 1.6.1 (0.43s)
Creating working copy for https://github.com/compnerd/cassowary.git
Working copy of https://github.com/compnerd/cassowary.git resolved at main (5530573)
Creating working copy for https://github.com/apple/swift-log.git
Working copy of https://github.com/apple/swift-log.git resolved at 1.6.1
Creating working copy for https://github.com/apple/swift-collections.git
Working copy of https://github.com/apple/swift-collections.git resolved at 1.0.6
Creating working copy for https://github.com/compnerd/swift-com.git
Working copy of https://github.com/compnerd/swift-com.git resolved at ebbc617d3b7ba3a2023988a74bebd118deea4cc5
Building for debugging...
lld-link: warning: C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32UI.build\dynamic\App.swift.o: locally defined symbol imported: $s10SwiftWin3215ApplicationMainys5Int32VAD_SpySpys4Int8VGSgGSSSgAJtF (defined in C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\ApplicationMain.swift.o) [LNK4217]
lld-link: warning: C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32UI.build\dynamic\Label.swift.o: locally defined symbol imported: $s10SwiftWin325LabelC5frameAC12CoreGraphics4RectV_tcfC (defined in C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\Label.swift.o) [LNK4217]
lld-link: warning: C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32UI.build\dynamic\Label.swift.o: locally defined symbol imported: $s10SwiftWin325LabelCMn (defined in C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\Label.swift.o) [LNK4217]
lld-link: warning: C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32UI.build\dynamic\UIApplicationDelegateAdaptor.swift.o: locally defined symbol imported: $s10SwiftWin3219ApplicationDelegateMp (defined in C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\ApplicationDelegate.swift.o) [LNK4217]
lld-link: error: undefined symbol: $s8SwiftCOM17IWICBitmapDecoderCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\Image.swift.o:($s10SwiftWin325ImageC4size12CoreGraphics4SizeVvgTq)

lld-link: error: undefined symbol: $s8SwiftCOM21IWICBitmapFrameDecodeCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\Image.swift.o:($s10SwiftWin325ImageC4size12CoreGraphics4SizeVvgTq)

lld-link: error: undefined symbol: $s8SwiftCOM19IWICFormatConverterCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\Image.swift.o:($s10SwiftWin325ImageC4size12CoreGraphics4SizeVvgTq)

lld-link: error: undefined symbol: $s8SwiftCOM8COMErrorVN
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerCACSgyc33_D635A01E19CD4366CF553150BE02DBEDLlfc)
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerCACSgyc33_D635A01E19CD4366CF553150BE02DBEDLlfc)
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerCACSgyc33_D635A01E19CD4366CF553150BE02DBEDLlfc)

lld-link: error: undefined symbol: $s8SwiftCOM13ISensorEventsCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerC6sharedACSgvpMV)

lld-link: error: undefined symbol: $s8SwiftCOM8IUnknownCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerC6sharedACSgvpMV)

lld-link: error: undefined symbol: $s8SwiftCOM8IUnknownC4pUnkACSvSg_tcfCTq
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerC6sharedACSgvpMV)

lld-link: error: undefined symbol: $s8SwiftCOM14ISensorManagerCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerCACSgyc33_D635A01E19CD4366CF553150BE02DBEDLlfCTq)

lld-link: error: undefined symbol: $s8SwiftCOM7ISensorCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerCACSgyc33_D635A01E19CD4366CF553150BE02DBEDLlfCTq)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
lld-link: error: undefined symbol: $s8SwiftCOM17IWICBitmapDecoderCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\Image.swift.o:($s10SwiftWin325ImageC4size12CoreGraphics4SizeVvgTq)

lld-link: error: undefined symbol: $s8SwiftCOM21IWICBitmapFrameDecodeCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\Image.swift.o:($s10SwiftWin325ImageC4size12CoreGraphics4SizeVvgTq)

lld-link: error: undefined symbol: $s8SwiftCOM19IWICFormatConverterCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\Image.swift.o:($s10SwiftWin325ImageC4size12CoreGraphics4SizeVvgTq)

lld-link: error: undefined symbol: $s8SwiftCOM8COMErrorVN
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerCACSgyc33_D635A01E19CD4366CF553150BE02DBEDLlfc)
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerCACSgyc33_D635A01E19CD4366CF553150BE02DBEDLlfc)
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerCACSgyc33_D635A01E19CD4366CF553150BE02DBEDLlfc)

lld-link: error: undefined symbol: $s8SwiftCOM13ISensorEventsCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerC6sharedACSgvpMV)

lld-link: error: undefined symbol: $s8SwiftCOM8IUnknownCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerC6sharedACSgvpMV)

lld-link: error: undefined symbol: $s8SwiftCOM8IUnknownC4pUnkACSvSg_tcfCTq
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerC6sharedACSgvpMV)

lld-link: error: undefined symbol: $s8SwiftCOM14ISensorManagerCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerCACSgyc33_D635A01E19CD4366CF553150BE02DBEDLlfCTq)

lld-link: error: undefined symbol: $s8SwiftCOM7ISensorCMn
>>> referenced by C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\SwiftWin32.build\OrientationSensor.swift.o:($s10SwiftWin3224OrientationSensorManagerCACSgyc33_D635A01E19CD4366CF553150BE02DBEDLlfCTq)
[599/602] Linking C:\Users\hiroshi\swift-win32\.build\x86_64-unknown-windows-msvc\debug\Calculator.exe

[dschaefer2]

This could be the SwiftPM change I made. I'll take a look.

[dschaefer2]

From @compnerd

I think that this is a modelling issue. The problem is that there are two libraries SwiftWin32UI and SwiftWin32. SwiftWin32UI depends on SwiftWin32. SwiftWin32 however has a dependency on SwiftCOM which is package external and has a dynamic library product. When the SwiftWin32 product is built (dynamic library), we link dynamically to SwiftCOM and everything is happy. When building SwiftWin32UI, we statically link against SwiftWin32. This uses the object library for SwiftWin32. However, this object library was built against the static library (object library) for SwiftCOM. We now attempt to link with SwiftCOM.lib (the import library for SwiftCOM) which assumes dynamic linking for symbols that we are expecting statically as we are building against the static library.

[dschaefer2]

I'll revert and make sure this is working before resubmitting. #8112

[dschaefer2]

Tested with latest 6.1 toolchain.