Skip to content

Add ability for dashboard script to work with current and proposed schemas #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Add ability for dashboard script to work with current and proposed schemas #602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2da3781
Add ability for dashboard script to work with current and proposed sc…
dempseyatgithub Mar 19, 2024
5f2b2dc
Restore accidentally removed error check
dempseyatgithub Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions assets/javascripts/swift-evolution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,16 @@ function init() {
var req = new window.XMLHttpRequest()

req.addEventListener('load', function() {
proposals = JSON.parse(req.responseText)

let evolutionMetadata = JSON.parse(req.responseText, flattenStatus)

// Temporary conditional to allow script to work with old and new schemas
if (Array.isArray(evolutionMetadata)) { // current schema
proposals = evolutionMetadata
} else { // new schema
proposals = evolutionMetadata.proposals
languageVersions = evolutionMetadata.implementationVersions
}

// Don't display malformed proposals
proposals = proposals.filter(function (proposal) {
return !proposal.errors
Expand Down Expand Up @@ -201,6 +209,18 @@ function init() {
req.send()
}

/**
* Reviver function passed to JSON.parse() to convert new status field structure to old structure.
*/
function flattenStatus(key, value) {
if (key == "status" && value !== "" && !value.state) {
let [subkey, subvalue] = Object.entries(value)[0]
subvalue.state = "." + subkey
return subvalue
}
return value
}

/**
* Creates an Element. Convenience wrapper for `document.createElement`.
*
Expand Down