-
Notifications
You must be signed in to change notification settings - Fork 253
Overhauled debugging memory leaks #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@0xTim - Hi Tim! :-) @FranzBusch suggested I work with you on this next documentation overhaul (similar to Why Swift on Server). Thank you! |
|
Hi @0xTim, Could you please take a look at these changes when you have a chance? Franz will be OOO until April 4. However, this content has already been vetted by him and would love your input. Many thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @RobinBateman808 - overall looks great! A few things to tweak and then we can merge
Co-authored-by: Tim Condon <[email protected]>
Co-authored-by: Tim Condon <[email protected]>
Co-authored-by: Tim Condon <[email protected]>
Co-authored-by: Tim Condon <[email protected]>
@OxTim - I committed your suggestions and left a couple of comments where I need more clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xTim - Thanks for reviewing and your feedback. I think we're almost there. :-) I just have a couple questions that need clarification. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Made suggested changes, removed some wordiness, and tightened up spacing.
|
@0xTim - thanks for your time and reviews. I think we are there. I made the minor changes you suggested. I also removed some wordiness and tightened up spacing w/in the syntax. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great thanks! 🙌
|
@swift-ci please test |
Motivation:
Edited for further clarification and usefulness.
Modifications:
Expanded definitions and meanings, completed sentence structures, formatted for ease of readability, included extra links/instructions, etc.
Result:
Aims to improve helpfulness. Notably, for those who are less familiar or new to Swift on Server.