Skip to content

Conversation

@RobinBateman808
Copy link
Contributor

@RobinBateman808 RobinBateman808 commented Mar 1, 2024

Motivation:

Edited for further clarification and usefulness.

Modifications:

Expanded definitions and meanings, completed sentence structures, formatted for ease of readability, included extra links/instructions, etc.

Result:

Aims to improve helpfulness. Notably, for those who are less familiar or new to Swift on Server.

@RobinBateman808
Copy link
Contributor Author

@0xTim - Hi Tim! :-) @FranzBusch suggested I work with you on this next documentation overhaul (similar to Why Swift on Server). Thank you!

@RobinBateman808
Copy link
Contributor Author

RobinBateman808 commented Mar 7, 2024

Hi @0xTim, Could you please take a look at these changes when you have a chance? Franz will be OOO until April 4. However, this content has already been vetted by him and would love your input. Many thanks!

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @RobinBateman808 - overall looks great! A few things to tweak and then we can merge

Copy link
Contributor Author

@RobinBateman808 RobinBateman808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xTim - Thanks for reviewing and your feedback. I think we're almost there. :-) I just have a couple questions that need clarification. Thanks again!

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Made suggested changes, removed some wordiness, and tightened up spacing.
@RobinBateman808
Copy link
Contributor Author

RobinBateman808 commented Mar 19, 2024

@0xTim - thanks for your time and reviews. I think we are there. I made the minor changes you suggested. I also removed some wordiness and tightened up spacing w/in the syntax.

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks! 🙌

@0xTim 0xTim enabled auto-merge (squash) March 20, 2024 12:39
@0xTim
Copy link
Member

0xTim commented Mar 20, 2024

@swift-ci please test

@0xTim 0xTim merged commit 151ff65 into main Mar 20, 2024
@0xTim 0xTim deleted the robins-debug-memory-leaks branch March 20, 2024 12:40
cthielen pushed a commit to Joannis/swift-org-website that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants