Merged
Conversation
Contributor
|
@swift-ci test |
Contributor
Author
|
The test is success now. Can we merge it since all other PR's Linux test is blocked by this issue. @franklinsch |
franklinsch
approved these changes
Oct 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
Even the Head() init compiler bug is fixed on Swift main. The Linux test is still failed on my local machine.
If we run
swift testdirectly, we'll missing a lot of symbol since the tested API have change(Since as testReplacing). And according to XCTestManifests.swift we need to use swift test --generate-linuxmain to regenerate the test file.But it still falls because
swift test --generate-linuxmainis only valid on macOS now.Since tests are automatically discovered on all platforms now. We can simply remove the 2 files to solve the issue here.
Testing
Using the swift-5.5-release(
without the Head() bug, however it should can be reproduced with the main branch swift) on Ubuntu 2004 on Sat Oct 23 13:14:59 UTC 2021Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded