Skip to content

Fixup use of invalid implicit cast of strongly-typed enum to underlying type. #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fixup use of invalid implicit cast of strongly-typed enum to underlying type. #882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions include/llbuild/Basic/Tracing.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ struct TracingEngineTaskCallback {
};

// Engine Queue Processing
enum class EngineQueueItemKind {
enum class EngineQueueItemKind : int {
RuleToScan = 0,
InputRequest,
FinishedInputRequest,
Expand All @@ -171,12 +171,14 @@ enum class EngineQueueItemKind {
FindingCycle,
BreakingCycle,
};
typedef std::underlying_type<EngineQueueItemKind>::type EngineQueueItemKindTy;

struct TracingEngineQueueItemEvent {
TracingEngineQueueItemEvent(EngineQueueItemKind kind, char const *key)
: key(key) {
if (!TracingEnabled) return;
LLBUILD_TRACE_INTERVAL_BEGIN("engine_queue_item_event", "key:%s;kind:%d", key, kind);
LLBUILD_TRACE_INTERVAL_BEGIN("engine_queue_item_event", "key:%s;kind:%d",
key, static_cast<EngineQueueItemKindTy>(kind));
}

~TracingEngineQueueItemEvent() {
Expand Down