Add PackageModelSyntax.dll #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjyamauchi
requested review from
compnerd,
shahmishal and
tomerd
as code owners
|
CC @compnerd |
|
CC @DougGregor This should fix the issue with spm failing to run installed from the windows installer |
|
Oops the diff isn't correct. Fixing |
hjyamauchi
force-pushed
the
packagemodelsyntax
branch
from
f65b008 to
6a6f4d1
Compare
|
Fixed. Ready for review |
compnerd
approved these changes
Apr 26, 2024
|
@DougGregor I assume that this doesn't need to be pulled into release/6.0? Or should we get this cherry-picked? |
|
We do need this on 6.0; I've opened a cherry-pick at #285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects swiftlang/swift-package-manager#7467