[6.0][Android] Enable more code and tests (#871) #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Android] Enable more code and tests while disabling setting extended file attributes and a test creating a hard link, features not normally allowed on Android. * Remove incorrect WASI check
|
@jmschonfeld, need a CI run here, I just added this to my Android CI to build 6.0. |
|
@swift-ci please test |
|
Passed CI, @parkera, ready for review. |
parkera
approved these changes
Oct 2, 2024
|
We'll have to double check which 6.0 release this eventually gets into. I think it'll be post-6.0.2 now unless there is one more cherry pick. |
|
6.0.3 is fine, as long as I can retire it from my downstream patches eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This gets the remaining tests passing natively on Android while disabling setting extended file attributes and modifying a test that creates a hard link, features not normally allowed on Android. I also removed an incorrect WASI check I found.
Scope: Only affects Android, no other platforms' code is touched.
Issue: None
Original PRs: #871
Risk: None
Testing: Passed all CI on trunk and my testing locally.
Reviewer: @jmschonfeld
This is useful for me and others who distribute Android SDKs or a toolchain, and won't break anything for other platforms.