[6.0] URL.host should not return percent-encoded host #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
approved these changes
Sep 5, 2024
jrflat
added a commit
to jrflat/swift-foundation
that referenced
this pull request
Sep 23, 2024
jrflat
added a commit
to jrflat/swift-foundation
that referenced
this pull request
Sep 23, 2024
jrflat
added a commit
to jrflat/swift-foundation
that referenced
this pull request
Sep 23, 2024
shahmishal
pushed a commit
that referenced
this pull request
Sep 23, 2024
shahmishal
pushed a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes
URL.hostto match the behavior before the Swift URL implementation:Scope: Only impacts deprecated (but still used)
URL.hostfor URLs with an encoded host, restoring previous behaviorOriginal PR: #875
Risk: Low - minimal scope, one line change to restore behavior
Testing: Local, swift-ci, stable in
mainfor 2 weeksReviewer: @parkera @jmschonfeld