Update SF-0007 Subprocess to version 6 #1112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
FranzBusch
reviewed
Jan 7, 2025
| /// - output: A file descriptor to bind to the subprocess' standard output. | ||
| /// - error: A file descriptor to bind to the subprocess' standard error. | ||
| /// - Returns: the process identifier for the subprocess. | ||
| public static func runDeatched( |
There was a problem hiding this comment.
I'm still doubting we need this really. Why doesn't this work
Task {
await Subprocess.run(...)
}
Since this is an unstructured task that's never retained nor cancelled it should run forever and when the program exits nothing is waiting for the task to finish or cancels it.
There was a problem hiding this comment.
@FranzBusch Can you comment in the pitch thread?
There was a problem hiding this comment.
I did leave a comment regarding this already here: https://forums.swift.org/t/review-2nd-sf-0007-subprocess/76547/17
Just looked at the PR changes here again and wanted to emphasize again that I'm still not convinced we need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v6: String support, minor changes around IO and closure
sendingrequirements:Configurationbased overload forrunDetached.Sequence<UInt8>,Sequence<Data>andAsyncSequence<Data>(droppedAsyncSequence<UInt8>in favor ofAsyncSequence<Data>).isolationparameter for closure based.runmethods.sendingrequirement for closure passed to.run.ProcessIdentifier.processIDtoProcessIdentifier.value.TeardownStepto useDurationinstead of raw nanoseconds.some StringProtocolinput overloads forrun().CollectedResult.standard{Output|Error}toOutputWrapper, which offers convenient views to the outputs as Data and String with UTF8 encoding