[6.0.x] String+Path performance improvements and bug fixes #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Rewrote String+Path functions for performance and functionality. ~2-6x speedup. Fixed bugs where
.deletingLastPathComponent()didn't skip over trailing slashes, and where"/path/".deletingLastPathComponent()would delete the entire string instead of leaving the leading"/"(#980).Scope: Impacts various Foundation types like
URLthat use theseStringextensions on file paths.Original PR: #927
Risk: Low/Med - Well-tested to ensure correct behavior, but does touch several commonly used
Stringextensions.Testing: Added unit tests, local, swift-ci, stable in
mainfor over a monthReviewer: @jmschonfeld
Resolves #980 for
release/6.0