CMake: modulemap file override as build interface #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only be pulling in the modulemap file from the source directory when compiling against the build directory, not the installed location. The module-map-file override should only be applied as part of the build interface, not install interface. In cases where the sources are checked out and we are compiling a project against the install interface, we will run into a situation where the compiler sees the modulemap from both the installed location and the source directory and will complain.
compnerd
approved these changes
Oct 9, 2025
jmschonfeld
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only be pulling in the modulemap file from the source directory when compiling against the build directory, not the installed location. The module-map-file override should only be applied as part of the build interface, not install interface. In cases where the sources are checked out and we are compiling a project against the install interface, we will run into a situation where the compiler sees the modulemap from both the installed location and the source directory and will complain.