-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add soundness check #824
Conversation
I was just getting ready to ask about how we could integrate a formatting check. Really happy to see a common workflow for this 😄 The repo definitely won't pass the formatting check today (since we haven't been able to enforce it easily, I didn't want to add more burden to the contribution workflow). I'd be happy to take some time to figure out what my preferred format configuration should be and apply it throughout, though. @ahoppen @bnbarham If you have logistical reasons that it should match swift-syntax's format configuration, I can live with that, but I'd like to do something even more opinionated here. WDYT? |
.github/workflows/pull_request.yml
Outdated
api_breakage_check_enabled: true | ||
broken_symlink_check_enabled: true | ||
docs_check_enabled: true | ||
format_check_enabled: true | ||
license_header_check_enabled: false | ||
license_header_check_project_name: "Swift.org" | ||
shell_check_enabled: true | ||
unacceptable_language_check_enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these are enabled in the workflow by default, right? So we could omit all the : true
lines, right?
No description provided.