Create a GitHub action to create a release #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
release-action
branch
from
b9f24de
to
7859165
Compare
This should replace the script that I have locally to test swift-format for a release and at the same time expand the configurations that are being tested.
ahoppen
force-pushed
the
release-action
branch
from
7859165
to
a29f7e6
Compare
shahmishal
reviewed
Sep 30, 2024
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: | | ||
| if [[ "${{ github.triggering_actor }}" != "ahoppen" ]]; then |
There was a problem hiding this comment.
We should create a team for swift-format release, so it's not blocked on one person.
There was a problem hiding this comment.
My thought was that it’s pretty easy to modify the workflow to shift responsibilities. That way the responsibility transfer is explicit.
shahmishal
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Overall looks good, just one suggestion on using team to avoid being blocked on one person. You might want to add @bnbarham.
shahmishal
approved these changes
Sep 30, 2024
allevato
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should replace the script that I have locally to test swift-format for a release and at the same time expand the configurations that are being tested.
A sample run can be seen here: https://github.com/ahoppen/swift-format/actions/runs/11089874502