Add OrderedImports configuration to disable grouping by import type#1133
Merged
allevato merged 3 commits intoswiftlang:mainfrom Jan 13, 2026
Merged
Add OrderedImports configuration to disable grouping by import type#1133allevato merged 3 commits intoswiftlang:mainfrom
OrderedImports configuration to disable grouping by import type#1133allevato merged 3 commits intoswiftlang:mainfrom
Conversation
amja
requested review from
allevato,
hamishknight,
hborla and
rintaro
as code owners
amja
changed the title
OrderedImports configuration to disable grouping by input typeOrderedImports configuration to disable grouping by import type
allevato
reviewed
Jan 6, 2026
| ) | ||
| } | ||
|
|
||
| func testInvalidOrderingWithGroupingDisabled() { |
Member
There was a problem hiding this comment.
Can you add a test that includes some line comments and some non-import code lines intermixed with the imports to verify that the output is as expected in that case too?
Contributor
Author
There was a problem hiding this comment.
Thanks for this suggestion. Adding the test uncovered a couple of issues that I have also resolved!
If you have any more thoughts for edge cases I should test, please let me know :)
- Improve config naming for clarity. - Remove special array for combined import types. - Undo unrelated code style change. - Add a test and fix logic issues discovered by new test.
allevato
approved these changes
Jan 13, 2026
Member
allevato
left a comment
allevato
left a comment
There was a problem hiding this comment.
This looks good, thank you for working on it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the capability to disable grouping by import type (
@testable,@_implementationOnly, etc.) and only order the imports lexicographically.This is achieved via a configuration option
orderedImports.shouldGroupImportTypes.Updated testing and documentation to reflect this new option.
Closes #1128