Cleanup algorithms code #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete lots of dead code, get off of collections and onto iterators, simplify implementations.
|
@swift-ci please test |
|
@swift-ci please test |
natecook1000
reviewed
Oct 9, 2024
There was a problem hiding this comment.
This is great, @milseman! 👏🏻
Only nit is the public declarations on internal types.
Co-authored-by: Nate Cook <[email protected]>
Co-authored-by: Nate Cook <[email protected]>
milseman
commented
Oct 9, 2024
milseman
commented
Oct 9, 2024
|
@swift-ci please test |
natecook1000
approved these changes
Oct 9, 2024
milseman
added a commit
to milseman/swift-experimental-string-processing
that referenced
this pull request
Dec 19, 2024
Cleanup algorithms code Delete lots of dead code, get off of collections and onto iterators, simplify implementations. --------- Co-authored-by: Nate Cook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete lots of dead code, get off of collections and onto iterators, simplify implementations.