SE-0498: demangle now prevents returning truncated unicode scalars #3056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ktoso
commented
Dec 17, 2025
ktoso
commented
- Updated the 'truncated' case in DemanglingResult to use a required parameter for clarity.
- Enhanced explanation of the truncation behavior and ensured that the output remains valid UTF8.
Updated the 'truncated' case in DemanglingResult to use a required parameter for clarity. Enhanced explanation of the truncation behavior and ensured that the output remains valid UTF8.
xwu
reviewed
Dec 17, 2025
rjmccall
added
content change
ktoso
changed the title
younata
pushed a commit
that referenced
this pull request
Jan 26, 2026
…3056) * SE-0498: demangle not prevents returning truncated unicode scalars Updated the 'truncated' case in DemanglingResult to use a required parameter for clarity. Enhanced explanation of the truncation behavior and ensured that the output remains valid UTF8. * Update 0498-runtime-demangle.md * Update proposals/0498-runtime-demangle.md Co-authored-by: Xiaodi Wu <[email protected]> * make demangle() throw instead of return a result * include code comments from implementation --------- Co-authored-by: Stephen Canon <[email protected]> Co-authored-by: Xiaodi Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.