Packaging: Support using Tools Support Core dylib #1805
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Swift Package Manager used the SwiftBuild framework, it eventually caused duplicate Swift Tools Support Core (TSC) duplicate symbols which come from Swift Driver and Swift PM. Swift PM depends on SwiftBuild, which depends on SwiftDriver, which statically links TSC. Swift PM also has a statically linked dependency on TSC. The proper solution is to have SwiftDriver and SwiftPM both depend on the TSC dynamic library when SwiftPM depends on the SwiftBuild framework, which is determined by setting the SWIFTPM_SWBUILD_FRAMEWORK environment variable. rdar://144547608
bkhouri
force-pushed
the
t/main/support_SWIFTPM_SWBUILD_FRAMEWORK_env_var
branch
from
3d5878a to
bd16a1b
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Swift Package Manager used the SwiftBuild framework, it eventually caused duplicate Swift Tools Support Core (TSC) duplicate symbols which come from Swift Driver and Swift PM.
Swift PM depends on SwiftBuild, which depends on SwiftDriver, which statically links TSC. Swift PM also has a statically linked dependency on TSC.
The proper solution is to have SwiftDriver and SwiftPM both depend on the TSC dynamic library when SwiftPM depends on the SwiftBuild framework, which is determined by setting the SWIFTPM_SWBUILD_FRAMEWORK environment variable.
Steps:
rdar://144547608